Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix desc subgraph inputVar #5299

Merged
merged 4 commits into from
Feb 2, 2023
Merged

fix desc subgraph inputVar #5299

merged 4 commits into from
Feb 2, 2023

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Feb 1, 2023 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Before

-----+--------------+--------------+----------------+-------------------------------
|  5 | Subgraph     | 4            |                | outputVar: {                 |
|    |              |              |                |   "colNames": [],            |
|    |              |              |                |   "type": "DATASET",         |
|    |              |              |                |   "name": "__Subgraph_5"     |
|    |              |              |                | }                            |
|    |              |              |                | src: $-._vid                 |
|    |              |              |                | tag_filter:                  |
|    |              |              |                | edge_filter:                 |
|    |              |              |                | filter:                      |

Now:

-----+--------------+--------------+----------------+-------------------------------
|  5 | Subgraph     | 4            |                | outputVar: {                 |
|    |              |              |                |   "colNames": [],            |
|    |              |              |                |   "type": "DATASET",         |
|    |              |              |                |   "name": "__Subgraph_5"     |
|    |              |              |                | }                            |
|    |              |              |                | inputVar: __Dedup_4          |
|    |              |              |                | src: $-._vid                 |
|    |              |              |                | tag_filter:                  |
|    |              |              |                | edge_filter:                 |
|    |              |              |                | filter:                      |

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review labels Feb 1, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 77.63% // Head: 78.68% // Increases project coverage by +1.04% 🎉

Coverage data is based on head (91a8239) compared to base (52a177e).
Patch coverage: 92.30% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5299      +/-   ##
==========================================
+ Coverage   77.63%   78.68%   +1.04%     
==========================================
  Files        1110     1110              
  Lines       83382    83383       +1     
==========================================
+ Hits        64736    65608     +872     
+ Misses      18646    17775     -871
Impacted Files Coverage Δ
src/graph/planner/plan/Algo.cpp 42.71% <0.00%> (ø)
src/graph/executor/algo/SubgraphExecutor.cpp 96.72% <100.00%> (+1.72%) ⬆️
src/graph/executor/query/DataCollectExecutor.cpp 93.54% <100.00%> (+0.07%) ⬆️
src/common/memory/MemoryTracker.cpp 60.00% <0.00%> (-16.00%) ⬇️
src/common/memory/Memory.h 72.34% <0.00%> (-8.52%) ⬇️
src/common/memory/NewDelete.cpp 56.25% <0.00%> (-6.25%) ⬇️
src/storage/exec/FilterNode.h 90.90% <0.00%> (-4.33%) ⬇️
src/graph/executor/query/IndexScanExecutor.cpp 91.42% <0.00%> (-2.69%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 86.07% <0.00%> (-2.11%) ⬇️
src/common/process/ProcessUtils.cpp 84.70% <0.00%> (-1.18%) ⬇️
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sophie-Xie Sophie-Xie merged commit 7098d9a into vesoft-inc:master Feb 2, 2023
@wey-gu wey-gu mentioned this pull request Feb 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@xtcyclist xtcyclist Awaiting requested review from xtcyclist

@jievince jievince Awaiting requested review from jievince

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nevermore3 @codecov-commenter @yixinglu @Shylock-Hg @Sophie-Xie